Skip to content

Java: Model java.util.Optional lambda methods#7008

Merged
aschackmull merged 3 commits intogithub:mainfrom
JLLeitschuh:feat/JLL/java_optional_lambda_support
Nov 1, 2021
Merged

Java: Model java.util.Optional lambda methods#7008
aschackmull merged 3 commits intogithub:mainfrom
JLLeitschuh:feat/JLL/java_optional_lambda_support

Conversation

@JLLeitschuh
Copy link
Copy Markdown
Contributor

@JLLeitschuh JLLeitschuh commented Oct 29, 2021 •
edited
Loading

Adds support for the various lambda-accepting methods on java.util.Optional

@JLLeitschuh
Java: Model java.util.Optional lambda methods
c2a2a3a 
Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
@JLLeitschuh JLLeitschuh requested a review from a team as a code owner October 29, 2021 17:28
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 29, 2021

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Java Standard Library,``java.*``,3,510,30,13,,,7,,,10
+    Java Standard Library,``java.*``,3,519,30,13,,,7,,,10
-    Totals,,175,5332,408,13,6,10,107,33,1,66
+    Totals,,175,5341,408,13,6,10,107,33,1,66
  • Changes to framework-coverage-java.csv:
- java.util,,,420,,,,,,,,,,,,,,,,,,,,,15,405
+ java.util,,,429,,,,,,,,,,,,,,,,,,,,,15,414

aschackmull
aschackmull previously approved these changes Nov 1, 2021
View reviewed changes
smowton
smowton previously approved these changes Nov 1, 2021
View reviewed changes
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 1, 2021

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Java Standard Library,``java.*``,3,510,30,13,,,7,,,10
+    Java Standard Library,``java.*``,3,519,30,13,,,7,,,10
-    Totals,,175,5332,408,13,6,10,107,33,1,66
+    Totals,,175,5341,408,13,6,10,107,33,1,66
  • Changes to framework-coverage-java.csv:
- java.util,,,420,,,,,,,,,,,,,,,,,,,,,15,405
+ java.util,,,429,,,,,,,,,,,,,,,,,,,,,15,414

@aschackmull aschackmull merged commit e88bbfd into github:main Nov 1, 2021
@JLLeitschuh
Copy link
Copy Markdown
Contributor Author

JLLeitschuh commented Nov 1, 2021

@smowton can you add the hacktoberfest-accepted label to this PR for me?

@smowton
Copy link
Copy Markdown
Contributor

smowton commented Nov 1, 2021

AFAIK CodeQL doesn't participate in Hacktoberfest

@JLLeitschuh
Copy link
Copy Markdown
Contributor Author

JLLeitschuh commented Nov 1, 2021 •
edited
Loading

@smowton it doesn't matter if you participate or not, I can still get credit if you add the label.
@atorralba did it for me for #6917

@smowton
Copy link
Copy Markdown
Contributor

smowton commented Nov 1, 2021

ok, why not :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smowton smowton smowton approved these changes

@aschackmull aschackmull aschackmull left review comments

Assignees

No one assigned

Labels

documentation hacktoberfest-accepted Java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JLLeitschuh @smowton @aschackmull