Skip to content

C++: Fix typo in MallocSizeExpr - #2655

Merged
geoffw0 merged 1 commit into
masterfrom
jbj-patch-1
Jan 21, 2020
Merged

C++: Fix typo in MallocSizeExpr#2655
geoffw0 merged 1 commit into
masterfrom
jbj-patch-1

Conversation

@jbj

@jbj jbj commented Jan 21, 2020

Copy link
Copy Markdown
Contributor

The first argument is index 0, not 1.

The first argument is index 0, not 1.
@jbj jbj added the C++ label Jan 21, 2020
@jbj
jbj requested a review from geoffw0 January 21, 2020 08:10
@jbj
jbj requested a review from a team as a code owner January 21, 2020 08:10
@jbj

jbj commented Jan 21, 2020

Copy link
Copy Markdown
Contributor Author

Thanks to @nicowaisman for finding this bug.

@MathiasVP MathiasVP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffw0
geoffw0 merged commit 80997a3 into master Jan 21, 2020
@nicowaisman

Copy link
Copy Markdown

Actually, credit to Andres Lopez Luksenberg for letting me know.

@jbj
jbj deleted the jbj-patch-1 branch October 15, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants