Skip to content

JavaScript: Fix TransformStream constructor arity #22349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theinfosecguy wants to merge 1 commit into
base: main
Choose a base branch
from
+48 −2
Open

JavaScript: Fix TransformStream constructor arity #22349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions javascript/externs/web/streamsapi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,27 @@ var QueuingStrategy;


/**
* A transform stream (https://streams.spec.whatwg.org/#transform-stream).
* @record
*/
function TransformStream() {};
function ITransformStream() {};

/** @type {!WritableStream} */
ITransformStream.prototype.writable;

/** @type {!ReadableStream} */
ITransformStream.prototype.readable;


/**
* @constructor
* @implements {ITransformStream}
* @param {Object=} transformer
* @param {!QueuingStrategy=} writableStrategy
* @param {!QueuingStrategy=} readableStrategy
* @see https://streams.spec.whatwg.org/#ts-class
*/
function TransformStream(transformer, writableStrategy, readableStrategy) {};

/** @type {!WritableStream} */
TransformStream.prototype.writable;
Expand Down Expand Up @@ -120,7 +138,7 @@ ReadableStream.prototype.cancel = function(reason) {};
ReadableStream.prototype.getReader = function(opt_options) {};

/**
* @param {!TransformStream} transform
* @param {!ITransformStream} transform
* @param {!PipeOptions=} opt_options
* @return {!ReadableStream}
* @see https://streams.spec.whatwg.org/#rs-pipe-through
Expand Down
4 changes: 4 additions & 0 deletions javascript/ql/src/change-notes/2026-08-14-transformstream-constructor-arity.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The `js/superfluous-trailing-arguments` query no longer reports valid arguments passed to the `TransformStream` constructor.
1 change: 1 addition & 0 deletions javascript/ql/test/query-tests/LanguageFeatures/SpuriousArguments/SpuriousArguments.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
| reflection.js:7:15:7:18 | 1 | Superfluous arguments passed to $@. | reflection.js:1:1:1:23 | functio ... eturn;} | function f0 |
| reflection.js:12:18:12:18 | 2 | Superfluous argument passed to $@. | reflection.js:2:1:2:24 | functio ... eturn;} | function f1 |
| thisparameter.ts:4:11:4:12 | 45 | Superfluous argument passed to $@. | thisparameter.ts:1:1:1:45 | functio ... eturn;} | function foo |
| transformstream.ts:15:33:15:34 | {} | Superfluous argument passed to $@. | externs.js:48:1:48:76 | functio ... egy) {} | function TransformStream |
| tst.js:10:3:10:5 | g() | Superfluous argument passed to $@. | tst.js:1:1:4:1 | functio ... x+19;\\n} | function f |
| tst.js:31:15:31:18 | 2 | Superfluous arguments passed to $@. | externs.js:34:1:34:27 | functio ... str) {} | function String |
| tst.js:34:4:34:5 | 42 | Superfluous argument passed to $@. | tst.js:35:4:35:23 | function() {return;} | anonymous function |
Expand Down
8 changes: 8 additions & 0 deletions javascript/ql/test/query-tests/LanguageFeatures/SpuriousArguments/externs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,12 @@ function Number() {}

Number.parseFloat = function(num) {};

/**
* @param {*=} transformer
* @param {*=} writableStrategy
* @param {*=} readableStrategy
* @constructor
*/
function TransformStream(transformer, writableStrategy, readableStrategy) {}

/** @externs */
15 changes: 15 additions & 0 deletions javascript/ql/test/query-tests/LanguageFeatures/SpuriousArguments/transformstream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
class CustomTransformStream extends TransformStream<Uint8Array, number | string> {
constructor() {
super({
transform(chunk, controller) {
controller.enqueue(chunk);
}
});
}
}

new TransformStream();
new TransformStream({});
new TransformStream({}, {});
new TransformStream({}, {}, {});
new TransformStream({}, {}, {}, {}); // $ Alert
Loading