Skip to content

Java: Improve inline expectations test comments #21983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
owen-mc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Java: Improve inline expectations test comments #21983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89c1d66
Add SPURIOUS and MISSING alerts based on existing comments
owen-mc Jun 12, 2026
4bc083f
Remove confusing comments
owen-mc Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions java/ql/test/query-tests/Nullness/B.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ public void corrConds3(Object y) {
x = new Object();
}
if(y instanceof String) {
x.hashCode(); // $ Alert[java/dereferenced-value-may-be-null] // Spurious NPE - false positive
x.hashCode(); // $ SPURIOUS: Alert[java/dereferenced-value-may-be-null] // Spurious NPE - false positive
}
}

Expand All @@ -341,7 +341,7 @@ public void corrConds4(Object y) {
x = new Object();
}
if(!(y instanceof String)) {
x.hashCode(); // $ Alert[java/dereferenced-value-may-be-null] // Spurious NPE - false positive
x.hashCode(); // $ SPURIOUS: Alert[java/dereferenced-value-may-be-null] // Spurious NPE - false positive
}
}

Expand All @@ -351,23 +351,23 @@ public void corrConds5(Object y, Object z) {
x = new Object();
}
if(y == z) {
x.hashCode(); // $ Alert[java/dereferenced-value-may-be-null] // Spurious NPE - false positive
x.hashCode(); // $ SPURIOUS: Alert[java/dereferenced-value-may-be-null] // Spurious NPE - false positive
}

Object x2 = null;
if(y != z) {
x2 = new Object();
}
if(y != z) {
x2.hashCode(); // $ Alert[java/dereferenced-value-may-be-null] // Spurious NPE - false positive
x2.hashCode(); // $ SPURIOUS: Alert[java/dereferenced-value-may-be-null] // Spurious NPE - false positive
}

Object x3 = null;
if(y != z) {
x3 = new Object();
}
if(!(y == z)) {
x3.hashCode(); // $ Alert[java/dereferenced-value-may-be-null] // Spurious NPE - false positive
x3.hashCode(); // $ SPURIOUS: Alert[java/dereferenced-value-may-be-null] // Spurious NPE - false positive
}
}

Expand Down Expand Up @@ -462,7 +462,7 @@ public void loopCorrTest2(boolean[] a) {
cur = a[i];
if (!prev) {
// correctly guarded by !cur from the _previous_ iteration
x.hashCode(); // $ Alert[java/dereferenced-value-may-be-null] // Spurious NPE - false positive
x.hashCode(); // $ SPURIOUS: Alert[java/dereferenced-value-may-be-null] // Spurious NPE - false positive
} else {
x = new Object();
}
Expand All @@ -484,7 +484,7 @@ public void loopCorrTest3(String[] ss) {
t = new Object();
}
// correctly guarded by t: null -> String -> Object
x.hashCode(); // $ Alert[java/dereferenced-value-may-be-null] // Spurious NPE - false positive
x.hashCode(); // $ SPURIOUS: Alert[java/dereferenced-value-may-be-null] // Spurious NPE - false positive
}
}
}
Expand Down Expand Up @@ -573,7 +573,7 @@ public void testFinally2(int[] xs) {
} finally {
}
}
s.hashCode(); // $ Alert[java/dereferenced-value-may-be-null] // Spurious NPE - false positive
s.hashCode(); // $ SPURIOUS: Alert[java/dereferenced-value-may-be-null] // Spurious NPE - false positive
// CFG reachability does not distinguish abrupt successors
}
}
14 changes: 7 additions & 7 deletions java/ql/test/query-tests/Nullness/C.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ public void ex1(long[][][] a1, int ix, int len) {
long[][] a2 = null;
boolean haveA2 = ix < len && (a2 = a1[ix]) != null;
long[] a3 = null;
final boolean haveA3 = haveA2 && (a3 = a2[ix]) != null; // $ Alert[java/dereferenced-value-may-be-null] // NPE - false positive
if (haveA3) a3[0] = 0; // $ Alert[java/dereferenced-value-may-be-null] // NPE - false positive
final boolean haveA3 = haveA2 && (a3 = a2[ix]) != null; // $ SPURIOUS: Alert[java/dereferenced-value-may-be-null] // NPE - false positive
if (haveA3) a3[0] = 0; // $ SPURIOUS: Alert[java/dereferenced-value-may-be-null] // NPE - false positive
}

public void ex2(boolean x, boolean y) {
Expand All @@ -18,7 +18,7 @@ public void ex2(boolean x, boolean y) {
s2 = (s1 == null) ? null : "";
}
if (s2 != null)
s1.hashCode(); // $ Alert[java/dereferenced-value-may-be-null] // NPE - false positive
s1.hashCode(); // $ SPURIOUS: Alert[java/dereferenced-value-may-be-null] // NPE - false positive
}

public void ex3(List<String> ss) {
Expand Down Expand Up @@ -48,7 +48,7 @@ public void ex4(Iterable<String> list, int step) {
slice = new ArrayList<>();
result.add(slice);
}
slice.add(str); // $ Alert[java/dereferenced-value-may-be-null] // NPE - false positive
slice.add(str); // $ SPURIOUS: Alert[java/dereferenced-value-may-be-null] // NPE - false positive
++index;
iter.remove();
}
Expand Down Expand Up @@ -141,7 +141,7 @@ public void ex9(boolean cond, Object obj1) {
public void ex10(int[] a) {
int n = a == null ? 0 : a.length;
for (int i = 0; i < n; i++) {
int x = a[i]; // $ Alert[java/dereferenced-value-may-be-null] // NPE - false positive
int x = a[i]; // $ SPURIOUS: Alert[java/dereferenced-value-may-be-null] // NPE - false positive
if (x > 7)
a = new int[n];
}
Expand Down Expand Up @@ -216,7 +216,7 @@ public void ex15(Object o1, Object o2) {
if (o1 == o2) {
return;
}
if (o1.equals(o2)) { // $ Alert[java/dereferenced-value-may-be-null] // NPE - false positive
if (o1.equals(o2)) { // $ SPURIOUS: Alert[java/dereferenced-value-may-be-null] // NPE - false positive
return;
}
}
Expand All @@ -230,7 +230,7 @@ private Object getFoo16() {
public static void ex16(C c) {
int[] xs = c.getFoo16() != null ? new int[5] : null;
if (c.getFoo16() != null) {
xs[0]++; // $ Alert[java/dereferenced-value-may-be-null] // NPE - false positive
xs[0]++; // $ SPURIOUS: Alert[java/dereferenced-value-may-be-null] // NPE - false positive
}
}

Expand Down
72 changes: 36 additions & 36 deletions java/ql/test/query-tests/UseBraces/UseBraces.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,25 +11,25 @@ void test(boolean bb)
{
int x = 0, y;
int[] branches = new int[10];

// If-then statement

if(1==1)
{
f();
}
g(); // No alert
if(1==1)

if(1==1)
f();
g(); // No alert

if(1==1)
f(); // $ Alert
g(); // Alert
g();

if(1==1)
f(); g(); // $ Alert // Alert
f(); g(); // $ Alert

// If-then-else statement

Expand All @@ -41,29 +41,29 @@ void test(boolean bb)
{
g();
}

g(); // No alert

if(1==2)
f();
else
g();
f(); // No alert

if(true)
{
f();
}
else
f(); // $ Alert
g(); // Alert
g();

if(true)
{
f();
}
else
f(); g(); // $ Alert // Alert
f(); g(); // $ Alert

// While statement

Expand All @@ -80,44 +80,44 @@ void test(boolean bb)

while(bb )
f(); // $ Alert
g(); // Alert
g();
g(); // No alert

while(bb )
f(); g(); // $ Alert // Alert
f(); g(); // $ Alert


while(bb)
if (x != 0) x = 1;

// Do-while statement

do
f();
while(false);
g(); // No alert

// For statement
for(int i=0; i<10; ++i)
{
f();
}
g();

for(int i=0; i<10; ++i)
f();
g();

for(int i=0; i<10; ++i)
f(); // $ Alert
g(); // Alert
g();

for(int i=0; i<10; ++i)
f(); g(); // $ Alert // Alert
f(); g(); // $ Alert



// Foreach statement

for( int b : branches)
x += b;
f();
Expand All @@ -130,42 +130,42 @@ void test(boolean bb)

for( int b : branches)
f(); // $ Alert
g(); // Alert
g();

for( int b : branches)
f(); g(); // $ Alert // Alert
f(); g(); // $ Alert

// Nested ifs
if( true )
if(false)
f();
g(); // No alert

if( true )
if(false) // $ Alert
f();
g(); // Alert
g();

if( true )
;
else
else
if (false)
f();
g(); // No alert

if( true )
;
else
else
if (false)
f();
g(); // false negative
g(); // $ MISSING: Alert // false negative

if( true )
;
else if (false)
f(); // $ Alert
g(); // Alert
g();

// Nested combinations
if (true)
while (x<10)
Expand All @@ -175,7 +175,7 @@ else if (false)
if (true)
while (x<10) // $ Alert
f();
g(); // Alert
g();

while (x<10)
if (true)
Expand All @@ -185,7 +185,7 @@ else if (false)
while (x<10)
if (true) // $ Alert
f();
g(); // Alert
g();

if (true)
f();
Expand Down
4 changes: 2 additions & 2 deletions java/ql/test/query-tests/security/CWE-113/semmle/tests/ResponseSplitting.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ public void sanitizerTests(HttpServletRequest request, HttpServletResponse respo
response.setHeader("h", t.replace('\n', ' ').replace('\r', ' '));

// FALSE NEGATIVE: replace only some line breaks
response.setHeader("h", t.replace('\n', ' '));
response.setHeader("h", t.replace('\n', ' ')); // $ MISSING: Alert

// FALSE NEGATIVE: replace only some line breaks
response.setHeader("h", t.replaceAll("\r", ""));
response.setHeader("h", t.replaceAll("\r", "")); // $ MISSING: Alert

// GOOD: replace all linebreaks with a simple regex
response.setHeader("h", t.replaceAll("\n", "").replaceAll("\r", ""));
Expand Down
4 changes: 2 additions & 2 deletions java/ql/test/query-tests/security/CWE-190/semmle/tests/ArithmeticTainted.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public void main(String[] args) {
// FALSE NEGATIVE: stillTainted could still be very large, even
// after
// it has had arithmetic done on it
int output = stillTainted + 100;
int output = stillTainted + 100; // $ MISSING: Alert[java/tainted-arithmetic]
}
}

Expand Down Expand Up @@ -107,7 +107,7 @@ public void main(String[] args) {
}
int output = data + 1;
}

{
double x= Double.MAX_VALUE;
// OK: CWE-190 only pertains to integer arithmetic
Expand Down
6 changes: 3 additions & 3 deletions java/ql/test/query-tests/security/CWE-190/semmle/tests/Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public static void main(String[] args) {
// FALSE POSITIVE: the query check purely based on the type, it
// can't try to
// determine whether the value may in fact always be in bounds
i += j; // $ Alert[java/implicit-cast-in-compound-assignment]
i += j; // $ SPURIOUS: Alert[java/implicit-cast-in-compound-assignment]
}

// ArithmeticWithExtremeValues
Expand Down Expand Up @@ -224,7 +224,7 @@ public static void main(String[] args) {
// FALSE NEGATIVE: stillLarge could still be very large, even
// after
// it has had arithmetic done on it
int output = stillLarge + 100;
int output = stillLarge + 100; // $ MISSING: Alert[java/uncontrolled-arithmetic]
}
}

Expand Down Expand Up @@ -263,7 +263,7 @@ public static void main(String[] args) {
// FALSE NEGATIVE: stillLarge could still be very large, even
// after
// it has had arithmetic done on it
int output = stillLarge + 100;
int output = stillLarge + 100; // $ MISSING: Alert[java/uncontrolled-arithmetic]
}
}

Expand Down
Loading
Loading