Skip to content

Ruby: use dual graph for common module ancestor check #21463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
asgerf wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Ruby: use dual graph for common module ancestor check #21463

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e1f3b91
Create DualGraph.qll
asgerf Mar 12, 2026
83d9d58
Ruby: use dual graph for common module ancestor check
asgerf Mar 12, 2026
fb85c7f
Add missing overlay annotation
asgerf Mar 12, 2026
b26dcc0
Add overlay[caller?]
asgerf Mar 12, 2026
a109302
Stricter caching
asgerf Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add overlay[caller?]
  • Loading branch information
@asgerf
asgerf committed Mar 12, 2026
commit b26dcc088bbd4f2f5cbe24d76cfebb8ec68775fb
1 change: 1 addition & 0 deletions shared/util/codeql/util/DualGraph.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ module MakeDualGraph<LocationSig Location, DualGraphInputSig<Location> Input> {
* Holds if `node1` and `node2` have a common ancestor in the original graph, that is,
* there exists a node from which both nodes are reachable.
*/
overlay[caller?]
pragma[inline]
predicate hasCommonAncestor(Node node1, Node node2) {
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
// Note: `fastTC` only checks for non-empty paths, but there is no need to special-case
Expand Down