Skip to content

Go: separate max supported Go version from the Go version to install #21456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
owen-mc wants to merge 3 commits into
base: main
Choose a base branch
from
+33 −22
Open

Go: separate max supported Go version from the Go version to install #21456

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
362b154
Separate `maxGoVersion` into max supported and max to install
owen-mc Mar 11, 2026
1beffea
Add test
owen-mc Mar 11, 2026
73f268c
Update comments
owen-mc Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update comments 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
  • Loading branch information
@owen-mc
owen-mc and Copilot authored Mar 13, 2026
commit 73f268c32c360da4e5a7a796bf0ccf0aa726486d
4 changes: 2 additions & 2 deletions go/extractor/autobuilder/build-environment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,15 @@ func getVersionWhenGoModVersionNotFound(v versionInfo) (msg string, version util
if v.goEnvVersion == nil {
// There is no Go version installed in the environment. We have no indication which version
// was intended to be used to build this project. Go versions are generally backwards
// compatible, so we install the maximum supported version.
// compatible, so we install the maximum supported released version.
msg = "No version of Go installed and no `go.mod` file found. Requesting the maximum " +
"supported version of Go that has been released (" + goVersionToInstall.String() + ")."
version = goVersionToInstall
Comment thread
owen-mc marked this conversation as resolved.
diagnostics.EmitNoGoModAndNoGoEnv(msg)
} else if outsideSupportedRange(v.goEnvVersion) {
// The Go version installed in the environment is not supported. We have no indication
// which version was intended to be used to build this project. Go versions are generally
// backwards compatible, so we install the maximum supported version.
// backwards compatible, so we install the maximum supported released version.
msg = "No `go.mod` file found. The version of Go installed in the environment (" +
v.goEnvVersion.String() + ") is outside of the supported range (" + minGoVersion.String() + "-" +
maxGoVersion.String() + "). Requesting the maximum supported version of Go that has " +
Expand Down
Loading