Go: Use shared basic block lib #21224
Draft
+462
−158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // predicate nodeIsPostDominanceExit(Node node) { node instanceof ControlFlow::NormalExitNode } | ||
| } | ||
|
|
||
| private module BbImpl = BB::Make<Location, Input>; |
Check warning
Code scanning / CodeQL
Dead code Warning
Comment on lines
1682
to
1716
| this.succ0(pred, succ, t) | ||
| or | ||
| exists(Completion cmpl | | ||
| lastNode(this.getBody(), pred, cmpl) and | ||
| // last node of function body can be reached without going through a `defer` statement | ||
| pred = notDeferSucc0*(this.getEntry()) | ||
| | | ||
| // panic goes directly to exit, non-panic reads result variables first | ||
| if cmpl = Panic() then succ = MkExitNode(this) else succ = this.getEpilogueNode(0) | ||
| ( | ||
| ( | ||
| if cmpl = Panic() | ||
| then succ = MkExitNode(this) and t instanceof ExceptionSuccessor | ||
| else succ = this.getEpilogueNode(0) | ||
| ) and | ||
| t instanceof DirectSuccessor | ||
| ) | ||
| ) | ||
| or | ||
| lastNode(this.getBody(), pred, _) and | ||
| exists(DeferStmt defer | defer = this.getADeferStmt() | | ||
| succ = MkExprNode(defer.getCall()) and | ||
| // the last `DeferStmt` executed before pred is this `defer` | ||
| pred = notDeferSucc0*(MkDeferNode(defer)) | ||
| ) | ||
| or | ||
| exists(DeferStmt predDefer, DeferStmt succDefer | | ||
| predDefer = this.getADeferStmt() and | ||
| succDefer = this.getADeferStmt() | ||
| | | ||
| // reversed because `defer`s are executed in LIFO order | ||
| MkDeferNode(predDefer) = nextDefer(MkDeferNode(succDefer)) and | ||
| pred = MkExprNode(predDefer.getCall()) and | ||
| succ = MkExprNode(succDefer.getCall()) | ||
| ) | ||
| ) and | ||
| t instanceof DirectSuccessor | ||
| or | ||
| this.firstDefer(pred) and | ||
| ( | ||
| // conservatively assume that we might either panic (and hence skip the result reads) | ||
| // or not | ||
| succ = MkExitNode(this) | ||
| succ = MkExitNode(this) and t instanceof ExitSuccessor | ||
| or | ||
| succ = this.getEpilogueNode(0) | ||
| ) |
Check warning
Code scanning / CodeQL
Var only used in one side of disjunct Warning
| this.succ0(pred, succ, _) | ||
| } | ||
|
|
||
| pragma[nomagic] |
Check warning
Code scanning / CodeQL
Override with unmentioned parameter Warning
| pragma[nomagic] | ||
| override predicate succ0(ControlFlow::Node pred, ControlFlow::Node succ, SuccessorType t) { | ||
| ControlFlowTree.super.succ0(pred, succ, t) | ||
| or |
Check warning
Code scanning / CodeQL
Override with unmentioned parameter Warning
Check warning
Code scanning / CodeQL
Dead code Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.