Java: Add support for Struts 7.x package names #21221
Open
+15
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a88660f to
53823b1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Please disregard the original Copilot review, as the the code and PR description at that point had a misleading assumption about |
owen-mc
previously approved these changes
Jan 26, 2026
Updates Struts library to recognize both legacy xwork2 and new struts2 packages: - StrutsActions.qll: Add org.apache.struts2 alternatives for Action, Preparable, ActionSupport - StrutsConventions.qll: Add org.apache.struts2.action.Action alternative This maintains backward compatibility for analyzing Struts 2.x-6.x apps while supporting Struts 7.x which renamed packages from com.opensymphony.xwork2 to org.apache.struts2.
53823b1 to
ede05b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Struts 7.x renamed packages from
com.opensymphony.xwork2toorg.apache.struts2.This updates the CodeQL Struts library to recognize both the legacy xwork2 package names (Struts 2.x-6.x) and the new struts2 package names (Struts 7.x), maintaining backward compatibility while enabling analysis of applications using newer Struts versions.
Changes:
StrutsActions.qllto recognizeorg.apache.struts2.action.Action,org.apache.struts2.Preparable, andorg.apache.struts2.ActionSupportStrutsConventions.qllto recognizeorg.apache.struts2.action.Actionfor convention plugin detection