C++: Update tests after extractor changes#20514
Merged
jketema merged 1 commit intogithub:mainfrom Sep 28, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes a test case for the permissive mode in the C++ CodeQL library, along with its expected output files. The change appears to be cleaning up test files after extractor changes made the permissive mode test obsolete.
- Removes the permissive.cpp test file containing a function with const-correctness issues
- Removes the corresponding expected output files for calls and accesses queries
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cpp/ql/test/library-tests/permissive/permissive.cpp | Removes entire test file with permissive mode example |
| cpp/ql/test/library-tests/permissive/calls.expected | Removes expected output for function calls in permissive test |
| cpp/ql/test/library-tests/permissive/accesses.expected | Removes expected output for variable accesses in permissive test |
geoffw0
reviewed
Sep 25, 2025
Contributor
Author
I believe so. I think it's good to know that it still fails (as it should). |
geoffw0
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.