Skip to content

Change includes paths in autobuild.sh - #18563

Merged
dbartol merged 4 commits into
github:mainfrom
mrecachinas:patch-1
Jan 22, 2025
Merged

Change includes paths in autobuild.sh#18563
dbartol merged 4 commits into
github:mainfrom
mrecachinas:patch-1

Conversation

@mrecachinas

@mrecachinas mrecachinas commented Jan 22, 2025

Copy link
Copy Markdown
Member

This PR changes the includes paths to only look at .github/workflows/*.yml and .github/workflows/*.yaml because workflows cannot be nested under subdirectories in .github/workflows.

After further discussion, we've decided to add

include:.github/reusable_workflows/**/*.yml
include:.github/reusable_workflows/**/*.yaml

to support reusable workflows.

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@github-actions github-actions Bot added the Actions Analysis of GitHub Actions label Jan 22, 2025
@mrecachinas
mrecachinas marked this pull request as ready for review January 22, 2025 16:27
Copilot AI review requested due to automatic review settings January 22, 2025 16:27
@mrecachinas
mrecachinas requested a review from a team as a code owner January 22, 2025 16:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • actions/extractor/tools/autobuild.sh: Language not supported

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@adityasharad

Copy link
Copy Markdown
Collaborator

I recall this was deliberate - as we had an internal convention that additional reusable workflows from other repos could be checked out in some workflows under .github/workflows/<some standard name>/*.yml, and then called using local paths to the workflow file. Does that still hold?

Comment thread actions/extractor/tools/autobuild.sh
adityasharad
adityasharad previously approved these changes Jan 22, 2025

@adityasharad adityasharad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @dbartol are you happy with these changes?

@dbartol dbartol left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a corresponding PowerShell script for Windows machines that needs to be updated as well. I've pushed those changes, but can't add them to this PR because it's from your fork. Just do:

git fetch origin
git merge origin/dbartol/actions-include-pwsh
git push

@mrecachinas

Copy link
Copy Markdown
Member Author

@dbartol Done

@mrecachinas
mrecachinas requested a review from dbartol January 22, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Actions Analysis of GitHub Actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants