C#: Support SyntheticField in MaD. - #17346
Merged
Merged
Conversation
Contributor
Author
|
DCA looks good. |
michaelnebel
marked this pull request as ready for review
September 3, 2024 07:52
aschackmull
approved these changes
Sep 3, 2024
aschackmull
left a comment
Contributor
There was a problem hiding this comment.
Looks plausible. I didn't look thoroughly through the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that we have a bug in the C# Synthetic field implementation. Synthetic fields were only support when declared directly in QL and not in MaD.
To fix this we need to introduce an adapter that adds all mentioned synthetic fields from MaD rows as possible synthetic field names.