Dataflow: Make use of defaults for language-specific hooks.#14299
Merged
aschackmull merged 4 commits intogithub:mainfrom Sep 25, 2023
Merged
Dataflow: Make use of defaults for language-specific hooks.#14299aschackmull merged 4 commits intogithub:mainfrom
aschackmull merged 4 commits intogithub:mainfrom
Conversation
74d7787 to
ae278fc
Compare
hvitved
reviewed
Sep 25, 2023
| default int getAdditionalFlowIntoCallNodeTerm(ArgumentNode arg, ParameterNode p) { none() } | ||
|
|
||
| predicate golangSpecificParamArgFilter(DataFlowCall call, ParameterNode p, ArgumentNode arg); | ||
| default predicate golangSpecificParamArgFilter( |
Contributor
There was a problem hiding this comment.
Doesn't this need a bindingset?
Contributor
Author
There was a problem hiding this comment.
Yes, looks like it does. Will fix.
hvitved
approved these changes
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With default predicates we can get rid of some dummy hook implementations.