Java: Support precondition calls as guards (ODASA-7796). - #1189
Merged
Conversation
Contributor
Author
|
Query changes are looking good. All removed results were FPs and the two new results are TPs. |
yh-semmle
approved these changes
Apr 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #986.
Calls need to be at the end of basic blocks in order to function as guards, so we add a few additional exception edges to the CFG. We already include such edges for calls nested inside finally blocks, so an argument could be made for simply adding such edges to all calls, but that would require additional testing to check how much the CFG would grow, so this seems safer.