Observe shadow root on connected callback #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williammartin
commented
Feb 28, 2023
| } | ||
|
|
||
| attributeChangedCallback() { | ||
| render(() => html` |
Contributor
Author
There was a problem hiding this comment.
These are unrelated to the main change, just type errors.
|
👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.
|
Contributor
|
Great work @williammartin! LGTM 😉 |
keithamus
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While poking around and learning about catalyst I tried to use dynamic rendering on the shadow DOM for both a
parentand achildcustom web component. I was able to see the parent attach the child but the contents of the child were not attached to the DOM.Why tho?
The existing
lazyDefinecreates aMutationObserverthat listens to the entiredocument, but shadow roots live as a separate isolated node and so when the shadow root of theparentcontainedchild, the import callback held indynamicElementswas not being called.What's the fix?
We exported a new
observefunction which will observe for changes on the providedElementLike. Then in the controllerconnectedCallback, if there is ashadowRoot, we'll observe it.CC @keithamus who I paired on this with