Skip to content

Update target tests #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
koddsson merged 5 commits into from
May 6, 2022
Merged

Update target tests #225

koddsson merged 5 commits into from
May 6, 2022

Conversation

@koddsson
Copy link
Contributor

@koddsson koddsson commented May 6, 2022

Backport the target tests from use-delegates so that branch will be a easier PR to land.

koddsson and others added 4 commits May 6, 2022 15:26
@koddsson @keithamus
Rename findTarget tests
e89d825 
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
@koddsson @keithamus
Get test/target.ts from use-delegates
d07f6f4 
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
@koddsson @keithamus
Set esbuild target for tests to es2020
93b2e75 
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
@koddsson @keithamus
Update tests so that the pass
791fa47 
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
@koddsson koddsson requested a review from a team as a code owner May 6, 2022 14:28
@koddsson koddsson requested a review from srt32 May 6, 2022 14:28
@koddsson koddsson enabled auto-merge May 6, 2022 14:29
keithamus
keithamus approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@koddsson @keithamus
Ignore eslint error
e4c1f83 
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
@koddsson koddsson merged commit 25ed8e7 into main May 6, 2022
@koddsson koddsson deleted the update-target-tests branch May 6, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srt32 srt32 Awaiting requested review from srt32 srt32 was automatically assigned from github/web-systems-reviewers

1 more reviewer

@keithamus keithamus keithamus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@koddsson @keithamus @Claude @Codex