CIHelper: avoid using the name git.git for the pr-repo#1994
Merged
Conversation
Since GitGitGadget is currently being extended to handle projects other than Git, let's just settle on the naming `pr-repo` for the local clone of the GitHub repository whose Pull Requests are to be handled (and where GitGitGadget's state is recorded in the Git notes). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This was referenced Sep 2, 2025
webstech
approved these changes
Sep 2, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Sep 2, 2025
…-more-generic-name-for-pr-repo-clone, 2025-09-02))
github-actions bot
pushed a commit
to Bassamx93/gitgitgadget
that referenced
this pull request
Sep 2, 2025
…itgadget/use-more-generic-name-for-pr-repo-clone, 2025-09-02))
dscho
added a commit
that referenced
this pull request
Mar 4, 2026
GitGitGadget's GitHub Actions all implicitly use the [`defaultConfig`](https://github.com/gitgitgadget/gitgitgadget/blob/153badfc78153bb25d10e0e0d40c2cb3924d7f1b/lib/gitgitgadget-config.ts#L3-L45) that hard-codes the configuration of the OG GitGitGadget that supports the Git project (and the Git project _only_). However, for a long time there have been feature requests and musings towards using GitGitGadget also for other projects. GitGitGadget already _does_ have some beginnings of a support for other projects, e.g. the `IConfig` interface. With these changes, that interface gets extended a little, a validator is added that can verify whether or not an arbitrary object conforms to that interface, and then new inputs are introduced, accepting this (JSON-encoded) configuration as a user-provided string. The idea is that a project-specific fork of https://github.com/gitgitgadget/gitgitgadget-workflows/ contains this configuration in the `gitgitgadget-config.json` file in a dedicated `config` branch, from where it is synchronized via a GitHub workflow to the repository variable called `CONFIG`. This somewhat non-trivial setup allows the config to be conveniently tracked via Git, updated via Pull Requests, validated via GitHub workflows, and still to be used in a trivial manner in the main workflows via `${{ vars.CONFIG }}` (as opposed to having to play games with multi-branch checkouts or `curl`'ing a file from a different branch). This PR is step number 2 in that direction. Step number 1 was to register the [`cygwingitgadget` GitHub org](https://github.com/cygwingitgadget/) for experimenting with GitGitGadget support for a different mailing-list-based project than Git: Cygwin. That org is where I experimented with this change as well as with all the others leading up to gitgitgadget/gitgitgadget-github-app#7. This PR is stacked on top of #1993 and #1994
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since GitGitGadget is currently being extended to handle projects other than Git, let's just settle on the naming
pr-repofor the local clone of the GitHub repository whose Pull Requests are to be handled (and where GitGitGadget's state is recorded in the Git notes).