Skip to content

beam extra should install apache-beam#751

Merged
AbhiPrasad merged 1 commit intogetsentry:masterfrom
alexmojaki:fix-beam-extra
Jun 29, 2020
Merged

beam extra should install apache-beam#751
AbhiPrasad merged 1 commit intogetsentry:masterfrom
alexmojaki:fix-beam-extra

Conversation

@alexmojaki
Copy link
Copy Markdown
Contributor

https://pypi.org/project/beam/
https://pypi.org/project/apache-beam/

tox.ini gets this right, I guess nothing tests the setup extra.

Copy link
Copy Markdown
Contributor

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. cc @untitaker

Copy link
Copy Markdown
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx feel free to merge @AbhiPrasad

@AbhiPrasad AbhiPrasad merged commit 4a28a3b into getsentry:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants