feat: Use most compact JSON encoding#746
Merged
rhcarvalho merged 1 commit intomasterfrom Jun 29, 2020
Merged
Conversation
5dacf67 to
a6cfc35
Compare
This shrinks event sizes a bit, even when gzip'ed.
The compact representation is documented in the json module.
Alternatively, we can also look into using a custom encoder (that could
also handle datetime objects, instead of the current manual
serialization of those).
In the absence of proper benchmark data, consider a random transaction
event t:
>>> len(json.dumps(t)), len(json.dumps(t, separators=(',', ':')))
(82174, 78516)
That is 95.5% of the original size.
With gzip compression:
>>> len(gzips(json.dumps(t))), len(gzips(json.dumps(t, separators=(',', ':'))))
(13093, 12988)
That is 99.2% of the original size.
a6cfc35 to
cb2a8b6
Compare
untitaker
approved these changes
Jun 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shrinks event sizes a bit, even when gzip'ed.
The compact representation is documented in the json module.
Alternatively, we can also look into using a custom encoder (that could
also handle datetime objects, instead of the current manual
serialization of those).
In the absence of proper benchmark data, consider a random transaction
event t:
That is 95.5% of the original size.
With gzip compression:
That is 99.2% of the original size.