feat(serverless): Python Serverless nocode instrumentation#1004
Merged
ahmedetefy merged 29 commits intomasterfrom Feb 17, 2021
Merged
feat(serverless): Python Serverless nocode instrumentation#1004ahmedetefy merged 29 commits intomasterfrom
ahmedetefy merged 29 commits intomasterfrom
Conversation
…/python_serverless_nocode_instrumentation
…/python_serverless_nocode_instrumentation
iker-barriocanal
approved these changes
Feb 16, 2021
rhcarvalho
suggested changes
Feb 16, 2021
Contributor
rhcarvalho
left a comment
There was a problem hiding this comment.
@ahmedetefy could you please add a PR description with a rationale?
Contributor
Author
|
@rhcarvalho Added now, sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the feature of being able to instrument python SDK into AWS lambda function without requiring the user to explicitly install the sentry SDK or initialize it
What was done in the PR?
scripts/build-aws-layer.pytoscripts/build_aws_layer.pyso that it is importablebuild_aws_layer.pyso that the code is reusablescripts/init_serverless_sdk.pyto initialize serverless sdk and reinvoke the Aws lambda layer handler function once initializing is complete. It is added to serverless sdk zip when it is created but is not part of the official sdk