Skip to content

Fix ignoredErrors, ignoredTransactions and ignoredCheckIns being unset by external options - #4207

Merged
adinauer merged 2 commits into
mainfrom
fix/external-options-unset-filters
Feb 25, 2025
Merged

Fix ignoredErrors, ignoredTransactions and ignoredCheckIns being unset by external options#4207
adinauer merged 2 commits into
mainfrom
fix/external-options-unset-filters

Conversation

@adinauer

Copy link
Copy Markdown
Member

📜 Description

Fix ignoredErrors, ignoredTransactions and ignoredCheckIns being unset by external options if not present in any external config mechanism.

💡 Motivation and Context

Fixes #4205

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions

github-actions Bot commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 643.43 ms 767.64 ms 124.21 ms
Size 1.58 MiB 2.21 MiB 641.62 KiB

Previous results on branch: fix/external-options-unset-filters

Startup times

Revision Plain With Sentry Diff
7ea9ceb 418.40 ms 440.92 ms 22.52 ms

App size

Revision Plain With Sentry Diff
7ea9ceb 1.58 MiB 2.21 MiB 641.61 KiB

@lcian lcian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adinauer
adinauer merged commit afe9d2c into main Feb 25, 2025
@adinauer
adinauer deleted the fix/external-options-unset-filters branch February 25, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merging of undefined external option of type "list" overrides internal one actually defined

2 participants