POTEL 62 - Build PropagationContext from sampling decision - #3947
Merged
adinauer merged 15 commits intoDec 5, 2024
Conversation
adinauer
requested review from
markushi,
romtsn and
stefanosiano
as code owners
December 2, 2024 13:52
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a63c26b | 320.66 ms | 331.12 ms | 10.46 ms |
| 8e4417e | 392.53 ms | 399.55 ms | 7.02 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a63c26b | 1.65 MiB | 2.31 MiB | 676.08 KiB |
| 8e4417e | 1.65 MiB | 2.31 MiB | 676.07 KiB |
An error occurred while trying to automatically change base from
feat/potel-61-twp-sampling-decision
to
8.x.x
December 2, 2024 14:24
This reverts commit a90f316.
markushi
approved these changes
Dec 5, 2024
adinauer
deleted the
feat/build-propagation-context-from-sampling-decision
branch
December 5, 2024 09:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Build
PropagationContextfromSamplingDecisionmade bySentrySamplerinstead of parsing headers and potentially ignoring a sampling decision in case asentry-traceheader comes in with deferred sampling decision.💡 Motivation and Context
Support deferred sampling decision
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps