Fixed NPE when MDC contains null values. - #1364
Merged
Merged
Conversation
Contributor
|
@donbeave thanks for contributing. |
Codecov Report
@@ Coverage Diff @@
## main #1364 +/- ##
============================================
- Coverage 75.70% 75.69% -0.01%
- Complexity 1854 1858 +4
============================================
Files 185 185
Lines 6355 6362 +7
Branches 635 635
============================================
+ Hits 4811 4816 +5
- Misses 1256 1258 +2
Partials 288 288
Continue to review full report at Codecov.
|
marandaneto
reviewed
Mar 31, 2021
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
marandaneto
approved these changes
Mar 31, 2021
1 task
4 tasks
marandaneto
reviewed
Apr 8, 2021
| // remove keys with null values, there is no sense to send these keys to Sentry | ||
| final Map<String, String> mdcProperties = | ||
| CollectionUtils.shallowCopy(loggingEvent.getMDCPropertyMap()); | ||
| loggingEvent.getMDCPropertyMap().entrySet().stream() |
Contributor
There was a problem hiding this comment.
mind doing the same fix for log4j2 SentryAdapter? it's pretty much the same thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for this issue: #1361.