Skip to content

ci(warden): Pass Warden Service URL and token to the review job - #210

Merged
gricha merged 1 commit into
mainfrom
ci/warden-service-credentials
Aug 15, 2026
Merged

ci(warden): Pass Warden Service URL and token to the review job#210
gricha merged 1 commit into
mainfrom
ci/warden-service-credentials

Conversation

@oioki

@oioki oioki commented Aug 14, 2026

Copy link
Copy Markdown
Member

Expose the org-wide WARDEN_SERVICE_URL variable and WARDEN_SERVICE_TOKEN secret to the Warden job so the action can reach Warden Service.

The URL is read from the vars context rather than env. Org and repository variables are only available through vars; reading it from env would self-reference the job's own env block and silently resolve to an empty string.

Two things worth a reviewer's eye:

  • Access policy. If the org variable/secret were created with "Selected repositories," every repo relying on this reusable workflow needs to be in the access list. Otherwise both expressions resolve to empty with no error and the action just sees unset env vars.
  • No fail-fast. Unlike WARDEN_OPENROUTER_API_KEY, which the "Check Warden credentials" step gates on with a != '' check, a missing service URL or token will not fail the job. Left as-is deliberately so Warden reviews keep working if Warden Service is unconfigured or down, but happy to add a check if we would rather know loudly.

Draft until the org-level access policy is confirmed to cover the repos using this workflow.

Expose the org-wide WARDEN_SERVICE_URL variable and WARDEN_SERVICE_TOKEN
secret to the Warden job so the action can reach Warden Service.

The URL comes from the `vars` context rather than `env`, since org and
repository variables are only available through `vars` — reading it from
`env` would self-reference the job's own env block and resolve to an
empty string.

Co-Authored-By: Claude <noreply@anthropic.com>
@oioki
oioki requested a review from gricha August 14, 2026 15:08
@gricha
gricha marked this pull request as ready for review August 15, 2026 05:46
@gricha
gricha merged commit ebaf989 into main Aug 15, 2026
9 of 10 checks passed
@gricha
gricha deleted the ci/warden-service-credentials branch August 15, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants