[#256] Flag to disable static request recording - #288
Closed
mavwolverine wants to merge 0 commit into
Closed
Conversation
Contributor
Author
|
@apotterri @brikelly Let me know your thoughts. |
apotterri
marked this pull request as ready for review
February 29, 2024 20:46
apotterri
marked this pull request as draft
February 29, 2024 20:49
apotterri
self-requested a review
March 1, 2024 15:16
apotterri
suggested changes
Mar 1, 2024
apotterri
left a comment
Contributor
There was a problem hiding this comment.
Thanks very much for this. I suggested one minor change.
It was also be very helpful it you could add a test or two.
(Also, FYI, Brian is no longer with AppMap.)
|
|
||
| self._configure_logging() | ||
| self._enabled = self._env.get("APPMAP", "").lower() != "false" | ||
| self._enabled_static_request_recordings = self._env.get("APPMAP_ENABLED_STATIC_REQUEST_RECORDINGS", "").lower() != "false" |
Contributor
There was a problem hiding this comment.
Maybe APPMAP_RECORD_STATIC_REQUESTS instead? That would be somewhat more consistent with other env vars.
Contributor
Author
There was a problem hiding this comment.
@apotterri I had thought of it at first, but then thought it might interfere with https://github.com/getappmap/appmap-python/blob/master/_appmap/env.py#L18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APPMAP_ENABLED_STATIC_REQUEST_RECORDINGS=false flask --app main runSubmitting draft code - please adapt as seen fit.