feat(config): read microgrid entries from assets.microgrid - #124
Merged
Conversation
cwasicki
requested review from
Mohammad-Tayyab-Frequenz and
llucax
and removed request for
a team
August 17, 2026 18:42
Microgrids are only the first entity these files describe; gridpools, market locations and the relations between them follow, and bare numeric top-level keys leave nowhere to put them. The namespace also makes the file mergeable with other config sources. A key like `23.meta.name` claims the top level outright and says nothing about what it identifies, so it can collide with unrelated settings and is unreadable as a deployment override. Under `assets` the generated inventory stays apart from the operator settings in `app.*`, and two sources writing the same key now genuinely mean the same microgrid. Top-level entries still load, with a deprecation warning, until the config files have migrated. A file carrying both layouts is rejected: it is a half-finished migration rather than a merge. Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
Collaborator
Author
|
Renamed the field to |
Mohammad-Tayyab-Frequenz
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microgrids are only the first entity these files describe; gridpools, market locations and the relations between them follow, and bare numeric top-level keys leave nowhere to put them.
The namespace also makes the file mergeable with other config sources. A key like
23.meta.nameclaims the top level outright and says nothing about what it identifies, so it can collide with unrelated settings and is unreadable as a deployment override. Underassetsthe generated inventory stays apart from the operator settings inapp.*, and two sources writing the same key now genuinely mean the same microgrid.Top-level entries still load, with a deprecation warning, until the config files have migrated. A file carrying both layouts is rejected: it is a half-finished migration rather than a merge.