Skip to content

fix(curriculum): preventing hardcoding answers in lab-depth-first-search #65507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
its-cutie-valerie wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(curriculum): preventing hardcoding answers in lab-depth-first-search #65507

its-cutie-valerie wants to merge 2 commits into from

Conversation

@its-cutie-valerie
Copy link
Contributor

@its-cutie-valerie its-cutie-valerie commented Jan 26, 2026

Checklist:

Closes #65436

Updated DFS lab tests to prevent hardcoded solutions by injecting hidden randomized graph and cycle checks into every test case.

@its-cutie-valerie its-cutie-valerie requested review from a team as code owners January 26, 2026 13:09
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2026

Thanks for your pull request.

Please do not add commits via the GitHub Web UI.

It generally means you have yet to test these changes in a development setup or complete any prerequisites. We need you to follow the guides mentioned in the checklist. Please revalidate these changes in a developer environment and confirm how you validated your changes.

Happy contributing!

Note: This message was automatically generated by a bot. If you feel this message is in error or would like help resolving it, feel free to reach us in our contributor chat.

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Jan 26, 2026
majestic-owl448
majestic-owl448 reviewed Jan 26, 2026
View reviewed changes
Copy link
Contributor

@majestic-owl448 majestic-owl448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the order in the result does not matter, the tests where specifically designed for that

you should not add hidden random tests to each test case, that makes it difficult to test, instead a last test that say something like "The function should work with any input" or something is a more user friendly approach

@majestic-owl448 majestic-owl448 added the deprioritized PR reviews are deprioritized; lacks productive input and ignores codebase best practices. label Jan 26, 2026
@its-cutie-valerie
Copy link
Contributor Author

its-cutie-valerie commented Jan 26, 2026

the order in the result does not matter, the tests where specifically designed for that

you should not add hidden random tests to each test case, that makes it difficult to test, instead a last test that say something like "The function should work with any input" or something is a more user friendly approach

Ah, okay... I'll do that then. Thank you for the info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majestic-owl448 majestic-owl448 majestic-owl448 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

deprioritized PR reviews are deprioritized; lacks productive input and ignores codebase best practices. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hardcoding answers in lab-depth-first-search

2 participants

@its-cutie-valerie @majestic-owl448