fix(curriculum): use — consistently in workshop-quincys-job-tips #65505
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
tests are failing, double check which test is it and please adjust it |
Contributor
Author
@majestic-owl448 Thanks for the review! I rechecked the failing test and realized the issue is the reverse of what I thought. The test uses innerText, which returns rendered text, not HTML. When The fix is to update the test assertion to check for I’ll update the PR with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.Closes #65331
This updates Step 10 of the Quincy’s Job Tips workshop to use the — HTML entity consistently across the description, seed content, and tests..