Transformers upgrade to 4.57.6#516
Merged
Merged
Conversation
Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
gkumbhat
reviewed
Mar 10, 2026
| ["hello how are you?", "a: this is a test. b: this is another test. a:"], | ||
| ] | ||
| use_cache_options = [True, False, None] | ||
| use_cache_options = [False] |
Collaborator
There was a problem hiding this comment.
Can you please add a comment here explaining why we are setting it to false now?
Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
gkumbhat
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newer versions of transformers have a parameter called
cache_positionthat would require implementation like was done in transformers to have full compatibility with the generation done in FMS. The way to disable this is by passinguse_cache=Falsein our tests that compare the output to transformers.