🐛 Fix vision features attention calculation#507
Merged
flaviabeo merged 1 commit intoFeb 16, 2026
Conversation
Signed-off-by: Gaurav-Kumbhat <Gaurav.Kumbhat@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes the differences in vision feature we were seeing. Because of the layout,
pixtralwas getting considered as causal model and thusis_causalwas getting set to True for doingscaled_dot_product_attention, whereas we are only using it as encoder for getting the image features inmistral3.py. Therefore, to resolve the issue, we are explicitly setting theattn_name=sdpa_bidirectionalwhen calling vision_tower in get_image_feature function.This makes the output of FMS look pretty similar to that of using transformers directly.