Skip to content

[doc] MultiHeadAttention: add kvheads to docstring#487

Merged
ani300 merged 3 commits into
foundation-model-stack:mainfrom
yannicks1:ysc-docstring-attention
Nov 24, 2025
Merged

[doc] MultiHeadAttention: add kvheads to docstring#487
ani300 merged 3 commits into
foundation-model-stack:mainfrom
yannicks1:ysc-docstring-attention

Conversation

@yannicks1

Copy link
Copy Markdown
Collaborator

kvheads, representing the number of key and value attention heads was missing in the MultiHeadAttention docstring. Also added the optional position_encoder and scale_factor args for completeness...

yannicks1 and others added 3 commits November 11, 2025 15:18
Signed-off-by: Yannick Schnider <yannick.schnider1@ibm.com>
Signed-off-by: Yannick Schnider <yannick.schnider1@ibm.com>

@ani300 ani300 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

@ani300 ani300 merged commit 777a623 into foundation-model-stack:main Nov 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants