Testing autosubmit bot -- updating testowners#185226
Open
gaaclarke wants to merge 3 commits intoflutter:masterfrom
Open
Testing autosubmit bot -- updating testowners#185226gaaclarke wants to merge 3 commits intoflutter:masterfrom
gaaclarke wants to merge 3 commits intoflutter:masterfrom
Conversation
Member
Author
|
@b-luk can you do a "request changes" review please? |
Contributor
|
I approve this next, and then you push another commit afterwards. Right? |
Member
Author
yea, please approve @b-luk |
Member
Author
Next steps are:
|
Contributor
|
Here's {
"reviews": [
{
"id": "PRR_kwDOAeUeuM72VMco",
"author": {
"login": "gemini-code-assist"
},
"authorAssociation": "CONTRIBUTOR",
"body": "## Code Review\n\nThis pull request updates the TESTOWNERS file to reassign the animated_complex_opacity_perf_macos__e2e_summary.dart test from @cbracken to @b-luk. I have no feedback to provide.",
"submittedAt": "2026-04-17T23:26:48Z",
"includesCreatedEdit": false,
"reactionGroups": [],
"state": "COMMENTED",
"commit": {
"oid": "ec6bd85a2a031805ee2493d9c835e5ef282dce9a"
}
},
{
"id": "PRR_kwDOAeUeuM72VRWb",
"author": {
"login": "b-luk"
},
"authorAssociation": "MEMBER",
"body": "Changes, please!",
"submittedAt": "2026-04-17T23:30:43Z",
"includesCreatedEdit": false,
"reactionGroups": [],
"state": "CHANGES_REQUESTED",
"commit": {
"oid": "ec6bd85a2a031805ee2493d9c835e5ef282dce9a"
}
},
{
"id": "PRR_kwDOAeUeuM72Vnke",
"author": {
"login": "b-luk"
},
"authorAssociation": "MEMBER",
"body": "LGTM",
"submittedAt": "2026-04-17T23:48:59Z",
"includesCreatedEdit": false,
"reactionGroups": [],
"state": "APPROVED",
"commit": {
"oid": "1a6b1c8e2084fb9727231a97c7e157eb86faa165"
}
}
]
}And after the new commit: {
"reviews": [
{
"id": "PRR_kwDOAeUeuM72VMco",
"author": {
"login": "gemini-code-assist"
},
"authorAssociation": "CONTRIBUTOR",
"body": "## Code Review\n\nThis pull request updates the TESTOWNERS file to reassign the animated_complex_opacity_perf_macos__e2e_summary.dart test from @cbracken to @b-luk. I have no feedback to provide.",
"submittedAt": "2026-04-17T23:26:48Z",
"includesCreatedEdit": false,
"reactionGroups": [],
"state": "COMMENTED",
"commit": {
"oid": "ec6bd85a2a031805ee2493d9c835e5ef282dce9a"
}
},
{
"id": "PRR_kwDOAeUeuM72VRWb",
"author": {
"login": "b-luk"
},
"authorAssociation": "MEMBER",
"body": "Changes, please!",
"submittedAt": "2026-04-17T23:30:43Z",
"includesCreatedEdit": false,
"reactionGroups": [],
"state": "CHANGES_REQUESTED",
"commit": {
"oid": "ec6bd85a2a031805ee2493d9c835e5ef282dce9a"
}
},
{
"id": "PRR_kwDOAeUeuM72Vnke",
"author": {
"login": "b-luk"
},
"authorAssociation": "MEMBER",
"body": "LGTM",
"submittedAt": "2026-04-17T23:48:59Z",
"includesCreatedEdit": false,
"reactionGroups": [],
"state": "DISMISSED",
"commit": {
"oid": "1a6b1c8e2084fb9727231a97c7e157eb86faa165"
}
}
]
}So there's a "CHANGES_REQUESTED" entry remaining from me, and the approved review went from "APPROVED" to "DISMISSED". The reviewer list in the Github UI does not show "changes requested" for me: |
jtmcdole
approved these changes
Apr 17, 2026
Contributor
|
State after jtmcdole's approval: {
"reviews": [
{
"id": "PRR_kwDOAeUeuM72VMco",
"author": {
"login": "gemini-code-assist"
},
"authorAssociation": "CONTRIBUTOR",
"body": "## Code Review\n\nThis pull request updates the TESTOWNERS file to reassign the animated_complex_opacity_perf_macos__e2e_summary.dart test from @cbracken to @b-luk. I have no feedback to provide.",
"submittedAt": "2026-04-17T23:26:48Z",
"includesCreatedEdit": false,
"reactionGroups": [],
"state": "COMMENTED",
"commit": {
"oid": "ec6bd85a2a031805ee2493d9c835e5ef282dce9a"
}
},
{
"id": "PRR_kwDOAeUeuM72VRWb",
"author": {
"login": "b-luk"
},
"authorAssociation": "MEMBER",
"body": "Changes, please!",
"submittedAt": "2026-04-17T23:30:43Z",
"includesCreatedEdit": false,
"reactionGroups": [],
"state": "CHANGES_REQUESTED",
"commit": {
"oid": "ec6bd85a2a031805ee2493d9c835e5ef282dce9a"
}
},
{
"id": "PRR_kwDOAeUeuM72Vnke",
"author": {
"login": "b-luk"
},
"authorAssociation": "MEMBER",
"body": "LGTM",
"submittedAt": "2026-04-17T23:48:59Z",
"includesCreatedEdit": false,
"reactionGroups": [],
"state": "DISMISSED",
"commit": {
"oid": "1a6b1c8e2084fb9727231a97c7e157eb86faa165"
}
},
{
"id": "PRR_kwDOAeUeuM72Vxya",
"author": {
"login": "jtmcdole"
},
"authorAssociation": "MEMBER",
"body": "",
"submittedAt": "2026-04-17T23:58:42Z",
"includesCreatedEdit": false,
"reactionGroups": [],
"state": "APPROVED",
"commit": {
"oid": "922af58a8241953028a960c9697128ebc536e5f6"
}
}
]
}
|
Contributor
|
autosubmit label was removed for flutter/flutter/185226, because This PR has not met approval requirements for merging. Changes were requested by {b-luk}, please make the needed changes and resubmit this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing for #185224
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.