Enable the avoid_final_parameters lint.#185216
Draft
kallentu wants to merge 4 commits intoflutter:masterfrom
Draft
Enable the avoid_final_parameters lint.#185216kallentu wants to merge 4 commits intoflutter:masterfrom
kallentu wants to merge 4 commits intoflutter:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avoid_final_parameterslint fires when using afinalmodifier in any parameter list. This is a preparatory lint that helps us migrate to Dart 3.13. All violations from this lint will become compile-time errors in Dart 3.13 when the primary constructors feature ships.Fixes: dart-lang/sdk#62590
Related to breaking changes: There should be nothing that breaks from adding this lint. Function types with
finalare already a compile-time error and any customers overriding a method with afinalparameter won't break their code.This change should be test exempt.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.