Clean-up the stack trace when throwing an assertion failure #3152
+1,804
−267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23ce804 to
a9d6ff7
Compare
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
2f09ec5 to
b7e6c5e
Compare
b7e6c5e to
92bac35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change marks a large portion of the library’s public and internal surface with the runtime’s
StackTraceHiddenattribute (only when running on .NET 6+), so failures and exceptions show cleaner stack traces that focus on user code instead of framework plumbing.As a result, assertion failures should be easier to read and debug because internal helper frames are suppressed by the debugger/stack trace renderer.
Alongside that, there are a few formatting-only tweaks (indentation/line breaks) that don’t affect behavior.
The public API baseline for .NET 6 reflects these added attributes so the API “shape” stays in sync.
Note The changes were a mix of AI and manual work, hence there's differences how the attribute was applied
Fixes #512