Skip to content

Keep decimal point in numbers specified as floats/doubles. - #2

Merged
fishbar merged 4 commits into
fishbar:masterfrom
bunchtogether:master
Jul 11, 2018
Merged

Keep decimal point in numbers specified as floats/doubles.#2
fishbar merged 4 commits into
fishbar:masterfrom
bunchtogether:master

Conversation

@wehriam

@wehriam wehriam commented Jun 6, 2017

Copy link
Copy Markdown

Prevents parsing errors in some SQL implementations that require a decimal point for doubles.

@fishbar

fishbar commented Jul 20, 2017

Copy link
Copy Markdown
Owner

ping @wehriam

@wehriam

wehriam commented Jul 20, 2017

Copy link
Copy Markdown
Author

You rang?

@fishbar

fishbar commented Jul 20, 2017

Copy link
Copy Markdown
Owner

@wehriam see the codereview below which i'v commented, chould you please adjust your code and push again. also, please merge all your commits into one commit , : )

@fishbar
fishbar merged commit 54d3f4f into fishbar:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants