Make GCF artifact cleanup guarded by an experiment #6861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abb206f to
326dc84
Compare
colerogers
approved these changes
Mar 15, 2024
|
We really would like to have this feature b/c at the moment we cannot re-route traffic to old deployments. Can you make an estimate when it will be merged? @inlined? |
…ontainercleanup-experiment
Member
Author
|
The API council can take some time. We decided to rename the experiment so that "deletegcfartifacts" and "automaticallydeletegcfartifacts" make sense together. Going to merge this PR imminently and then it will be part of next week's CLI release |
…ontainercleanup-experiment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL API COUNCIL HAS APPROVED THE CHANGE
Adds a default-on experiment that can be turned off to prevent functions from cleaning up old images. Will unblock customers unhappy in #6759
With this change, you can disable image cleanup with: