Skip to content

Conversation

@joehan
Copy link
Member

@joehan joehan commented May 17, 2022

Description

Throughout the functions and extensions emulator, use cross-spawn (instead of spawn) so that this works correctly on Windows environments. Fixes #4554

Scenarios Tested

Tested that the extensions emulator works as expected on MacOS and on my personal Windows machine.

@joehan joehan requested a review from bkendall May 17, 2022 21:27
@joehan joehan requested a review from yuchenshi May 18, 2022 16:28
@bkendall bkendall merged commit cd73661 into master May 18, 2022
@bkendall bkendall deleted the jh-cross-spawn branch May 18, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot run firebase emulators:start with storage-resize-images extension

2 participants