Allow Hosting deploys with no public dir in some circumstances.#3351
Merged
Allow Hosting deploys with no public dir in some circumstances.#3351
public dir in some circumstances.#3351Conversation
- When dynamic rewrites are present (and no static rewrites). - When redirects are present. Also refactors and TypeScript-ifies some of the Hosting deploy code.
bkendall
approved these changes
May 13, 2021
Contributor
bkendall
left a comment
There was a problem hiding this comment.
LGTM, but could the fixtures/simple be changed to fixtures/simplehosting? Otherwise other "simple" things are going to be lumped into it, I'm sure.
|
Please ask questions on Stack overflow. Not on this Pull Request |
|
Not needed anymore. I think GCF sucks. I moved to Vercel. It's better with SSR and functions. |
bkendall
added a commit
that referenced
this pull request
Jul 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows no
publicdirectory:Also refactors and TypeScript-ifies some of the Hosting deploy code.
Scenarios Tested
publicdirectory.publicdir but with afunctionrewrite.publicdir but with arunrewrite.publicdir but with a redirect.Fixes #3349