Skip to content

Fix to ensure that the installation ID is right set for sending events. #8578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
visumickey merged 6 commits into from
Aug 27, 2021
Merged

Fix to ensure that the installation ID is right set for sending events. #8578

visumickey merged 6 commits into from
Aug 27, 2021

Conversation

@visumickey
Copy link
Contributor

@visumickey visumickey commented Aug 27, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Aug 27, 2021
maksymmalyhin
maksymmalyhin approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would strongly recommend adding tests for the case.

@maksymmalyhin
Copy link
Contributor

maksymmalyhin commented Aug 27, 2021

Please fix or disable the tests.

@raymondlam
Copy link
Member

raymondlam commented Aug 27, 2021

LGTM. I would strongly recommend adding tests for the case.

+1

@visumickey
Copy link
Contributor Author

visumickey commented Aug 27, 2021

LGTM. I would strongly recommend adding tests for the case.

+1

These are now covered.

@google-oss-bot
Copy link
Collaborator

google-oss-bot commented Aug 27, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebasePerformance-iOS-FirebasePerformance.framework

    SDK overall coverage changed from 92.34% (77dae88) to 92.34% (e822812) by +0.00%.

    Filename Base (77dae88) Head (e822812) Diff
    FPRClient.m 59.32% 59.52% +0.20%

Test Logs

@visumickey visumickey requested review from maksymmalyhin and ncooke3 and removed request for paulb777 August 27, 2021 03:05
maksymmalyhin
maksymmalyhin reviewed Aug 27, 2021
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question on the memory management.

ncooke3
ncooke3 reviewed Aug 27, 2021
View reviewed changes
paulb777
paulb777 reviewed Aug 27, 2021
View reviewed changes
maksymmalyhin
maksymmalyhin approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@visumickey visumickey merged commit 0caef34 into master Aug 27, 2021
@visumickey visumickey deleted the perf_spmFix branch August 27, 2021 03:53
paulb777 pushed a commit that referenced this pull request Aug 27, 2021
@visumickey @paulb777
Fix to ensure that the installation ID is right set for sending event…
f23713f 
…s. (#8578)
ncooke3
ncooke3 approved these changes Aug 27, 2021
View reviewed changes
paulb777 pushed a commit that referenced this pull request Aug 27, 2021
@maksymmalyhin @visumickey
Bump FirePerf and Core versions to 8.6.1 (#8580)
38d4f0c 
* Bump FirePerf and Core versions to 8.6.1
* Fix to ensure that the installation ID is right set for sending events. (#8578)
Co-authored-by: Visu <visumickey@gmail.com>
@visumickey visumickey mentioned this pull request Aug 27, 2021
Closed
@visumickey visumickey linked an issue Aug 27, 2021 that may be closed by this pull request
Firebase Performance metrics disappears on the console after 2 days #8581
Closed
@firebase firebase locked and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ncooke3 ncooke3 ncooke3 approved these changes

@kim-f kim-f Awaiting requested review from kim-f

@raymondlam raymondlam Awaiting requested review from raymondlam

+2 more reviewers

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

@jeremyjiang-dev jeremyjiang-dev jeremyjiang-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: performance cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Firebase Performance metrics disappears on the console after 2 days

7 participants

@visumickey @maksymmalyhin @raymondlam @google-oss-bot @paulb777 @ncooke3 @jeremyjiang-dev