Skip to content

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jan 25, 2026

Add new reusable workflow that wraps the scripts/build.sh script and provides consolidated Xcode selection, simulator installation and log uploading.

  • Reduce # of places that we handle Xcode versioning (down to 38 times in .github/ from 56 with this PR)
  • Consolidate de-flaking logic for gem bundle installation, sim installation, build retries, and logs uploading (should reduce nightly flakes).
  • Experimenting with fixing CI management for forks.

#no-changelog

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@ncooke3 ncooke3 closed this Jan 25, 2026
@ncooke3 ncooke3 reopened this Jan 25, 2026
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR addresses the TODO for the new _build.yml workflow. I'd like to think more about how this can easily apply to other workflows without updating them all to set the HAVE_SECRETS env var. There is some more refactoring to be done, where revisiting this should be easier in the future.

@ncooke3
Copy link
Member Author

ncooke3 commented Jan 26, 2026

45e7793 was green.

@ncooke3
Copy link
Member Author

ncooke3 commented Jan 26, 2026

global tap had two unrelated flakes a6ab2b7

@ncooke3 ncooke3 closed this Jan 26, 2026
@ncooke3 ncooke3 reopened this Jan 26, 2026
@ncooke3 ncooke3 marked this pull request as ready for review January 26, 2026 17:19
@ncooke3 ncooke3 requested a review from a team as a code owner January 26, 2026 17:20
@paulb777
Copy link
Member

Looks like the Storage integration tests are NOT running https://github.com/firebase/firebase-ios-sdk/actions/runs/21367091022/job/61501729416

@ncooke3 ncooke3 marked this pull request as draft January 26, 2026 23:33
@ncooke3
Copy link
Member Author

ncooke3 commented Jan 26, 2026

Looks like the Storage integration tests are NOT running https://github.com/firebase/firebase-ios-sdk/actions/runs/21367091022/job/61501729416

@paulb777, great catch! That's not good. I think it's related to my check_secrets.sh changes. Converting to draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants