-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: add new reusable workflow, _build.yml #15762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR addresses the TODO for the new _build.yml workflow. I'd like to think more about how this can easily apply to other workflows without updating them all to set the HAVE_SECRETS env var. There is some more refactoring to be done, where revisiting this should be easier in the future.
|
45e7793 was green. |
|
global tap had two unrelated flakes a6ab2b7 |
|
Looks like the Storage integration tests are NOT running https://github.com/firebase/firebase-ios-sdk/actions/runs/21367091022/job/61501729416 |
@paulb777, great catch! That's not good. I think it's related to my check_secrets.sh changes. Converting to draft. |
Add new reusable workflow that wraps the scripts/build.sh script and provides consolidated Xcode selection, simulator installation and log uploading.
#no-changelog