Include subheaders in script output #10212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When selecting a specific version, we want to include all its subheaders in the generated output.
morganchen12
approved these changes
Sep 14, 2022
Contributor
Author
|
Hey @morganchen12 I don't have permissions to merge this PR, could you do it? Thanks! |
morganchen12
added a commit
that referenced
this pull request
Oct 19, 2022
This reverts commit 11313da.
morganchen12
added a commit
that referenced
this pull request
Oct 20, 2022
* Revert "Include subheaders in script output (#10212)" This reverts commit 11313da. * Revert "Revert "Add new danger check (#10338)" (#10355)" This reverts commit e190b63. * Add umbrella header check again * make warning for now * fix syntax error * Test danger * syntax error * actually fix syntaax * test 2 * lose sanity * test warning resolution * remove test changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting a specific version, we want to include all its subheaders in the generated output.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in a feature request so that we
can discuss it together.