Skip to content

Token-changed listeners for iOS AppCheck #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlmostMatt merged 16 commits into from
Dec 20, 2022
Merged

Token-changed listeners for iOS AppCheck #1172

AlmostMatt merged 16 commits into from
Dec 20, 2022

Conversation

@AlmostMatt
Copy link
Contributor

@AlmostMatt AlmostMatt commented Dec 16, 2022 •
edited
Loading

Description

Implements token-changed listeners for the iOS implementation of AppCheck

Testing

Added integration test cases to verify token-changed notification is received and token-changed listeners are called.
Integration tests passed when running locally.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@AlmostMatt AlmostMatt added the skip-release-notes Skip release notes check label Dec 16, 2022
a-maurice
a-maurice reviewed Dec 17, 2022
View reviewed changes
@AlmostMatt AlmostMatt requested a review from a-maurice December 19, 2022 21:39
@AlmostMatt AlmostMatt enabled auto-merge (squash) December 20, 2022 19:48
@AlmostMatt AlmostMatt merged commit c380832 into main Dec 20, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Dec 20, 2022
@github-actions
Copy link

github-actions bot commented Dec 20, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @AlmostMatt on commit c380832
Last updated: Tue Dec 20 14:18 PST 2022
View integration test log & download artifacts

Failures Configs
gma [TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: ios_target]
(2 failed tests)  FirebaseGmaTest.TestRewardedAdLoad
  FirebaseGmaTest.TestRewardedAdLoadEmptyRequest
storage [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 20, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 20, 2022
@AlmostMatt AlmostMatt deleted the amatt-ios-appcheck-listeners branch January 19, 2023 21:28
@firebase firebase locked and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees

No one assigned

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlmostMatt @a-maurice