Skip to content

Add appcheck-ktx to bom config #4081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vkryachko merged 1 commit into from
Sep 15, 2022
Merged

Add appcheck-ktx to bom config #4081

vkryachko merged 1 commit into from
Sep 15, 2022

Conversation

@vkryachko
Copy link
Member

@vkryachko vkryachko commented Sep 13, 2022

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2022

buildSrc Test Results

18 tests   18 ✔️  2m 26s ⏱️
  4 suites    0 💤
  4 files      0 ❌

Results for commit 2c19cff.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2022 •
edited
Loading

Unit Test Results

   394 files  ±0     394 suites  ±0   16m 54s ⏱️ - 1m 3s
4 717 tests ±0  4 695 ✔️ +1  22 💤 ±0  0 ❌  - 1 
4 733 runs  ±0  4 711 ✔️ +1  22 💤 ±0  0 ❌  - 1 

Results for commit 2c19cff. ± Comparison against base commit 5892717.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Collaborator

google-oss-bot commented Sep 13, 2022

Size Report 1

Affected Products

No changes between base commit (5892717) and merge commit (1f43a41).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qxFTLW7fT5.html

@google-oss-bot
Copy link
Collaborator

google-oss-bot commented Sep 13, 2022

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.13% (5892717) to 50.17% (1f43a41) by +0.04%.

    FilenameBase (5892717)Merge (1f43a41)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%

  • firebase-firestore

    Overall coverage changed from 44.43% (5892717) to 44.41% (1f43a41) by -0.02%.

    FilenameBase (5892717)Merge (1f43a41)Diff
    AbstractStream.java37.02%34.81%-2.21%
    SetMutation.java97.22%94.44%-2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/RrdV9JnmTK.html

@vkryachko vkryachko merged commit 6a566dd into master Sep 15, 2022
@vkryachko vkryachko deleted the vk.appcheck-ktx-bom branch September 15, 2022 18:08
qdpham13 pushed a commit that referenced this pull request Sep 20, 2022
@vkryachko @qdpham13
Add appcheck-ktx to bom config (#4081)
1e0672d
@firebase firebase locked and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rlazo rlazo rlazo approved these changes

@thatfiredev thatfiredev thatfiredev approved these changes

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vkryachko @google-oss-bot @rlazo @thatfiredev