Fix broken test (which relied on default timeout being None). - #396
Closed
rsgowman wants to merge 1 commit into
Closed
Fix broken test (which relied on default timeout being None).#396rsgowman wants to merge 1 commit into
rsgowman wants to merge 1 commit into
Conversation
The upstream behaviour has changed such that None is no longer the default: googleapis/google-auth-library-python#435
Member
Author
|
I don't know if there are other implications to this value changing...? |
Member
Author
|
Oh, never mind; I just noticed #395 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream behaviour has changed such that None is no longer the
default:
googleapis/google-auth-library-python#435