This repository was archived by the owner on Jun 14, 2022. It is now read-only.
Merged
Conversation
…sing from floats and from BinaryRecord objects from Python
… matrix construction. Use binary matrix helper routine in constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, our Python impl for parameters is limited to a single
f64as binary interaction parameter. This impl introducesTryFrom<f64>as trait bound in theParametertrait which allows to keep a simple Python interface where possible (i.e. if the EoS has a single binary parameter) but also allows for more complex binary interaction parameters.