Skip to content

Make binary_parameters in from_records optional and replace unwrap with panic with message#35

Merged
prehner merged 3 commits intomainfrom
fix_binary_parameter_input
Aug 8, 2022
Merged

Make binary_parameters in from_records optional and replace unwrap with panic with message#35
prehner merged 3 commits intomainfrom
fix_binary_parameter_input

Conversation

@g-bauer
Copy link
Copy Markdown
Contributor

@g-bauer g-bauer commented Jul 15, 2022

Fixes #28

  • Made binary parameters in from_records python routine an Option.
  • added panic with message when parsing missing Identifiers variants.

@prehner prehner modified the milestone: feos v0.3.0 Jul 27, 2022
@prehner prehner added the core related to features in feos-core label Jul 27, 2022
Comment thread CHANGELOG.md Outdated
@prehner prehner force-pushed the fix_binary_parameter_input branch from e4363a8 to a9ebd55 Compare August 8, 2022 12:14
@prehner prehner merged commit 052c291 into main Aug 8, 2022
@prehner prehner deleted the fix_binary_parameter_input branch August 8, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core related to features in feos-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PcSaftParameters.from_records can not be used without binary parameters

2 participants