Skip to content

Fix unexpected behavior in the initialization of bubble and dew point calculations #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prehner merged 2 commits into from
Mar 9, 2023
Merged

Fix unexpected behavior in the initialization of bubble and dew point calculations #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f92ff88
Fix unexpected behavior in the initialization of bubble and dew point…
prehner Mar 8, 2023
0564914
Add changelog entry
prehner Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions feos-core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased
### Fixed
- Fixed a bug that caused the bubble and dew point solvers to ignore the initial values for the opposing phase given by the user if no initial value for temperature/pressure was also given. [#138](https://github.com/feos-org/feos/pull/138)

## [0.4.0] - 2023-01-27
### Added
Expand Down
2 changes: 1 addition & 1 deletion feos-core/src/phase_equilibria/bubble_dew.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ impl<E: EquationOfState> PhaseEquilibrium<E, 2> {
tp_spec,
p,
molefracs_spec,
Some(&x),
molefracs_init.or(Some(&x)),
bubble,
options,
)
Expand Down