Overhaul generation of Python objects for EquationOfState.python #114
Merged
Overhaul generation of Python objects for EquationOfState.python #114
EquationOfState.python #114Conversation
… those dual numbers and to implement the HelmholtzEnergyDual trait for each state
ec3c75b to
557e42c
Compare
prehner
approved these changes
Jan 27, 2023
Contributor
prehner
left a comment
There was a problem hiding this comment.
Looks good! I added a changelog entry. I guess the naming is as it is, it is not really exposed anyways ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added macros to build
Currently based on github branch of
num-dual. Will changeCargo.tomlas soon as new version is published.Open questions
#[pyclass(name = ...)]PyStateDualDualVec3vsPyStateHDDVec2.