Conversation
prehner
commented
Jan 12, 2023
g-bauer
approved these changes
Jan 12, 2023
| } | ||
|
|
||
| /// Return logarithmic pure substance fugacity coefficient. | ||
| /// Return logarithmic fugacity coefficient of a pure liquid reference state. |
Contributor
There was a problem hiding this comment.
maybe change "liquid reference state" to "...of a pure liquid at mixture pressure and temperature" similar to the rust docstring?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
molar_volumeshould be calledpartial_molar_volumeto not be confused withV/N.Also #105 revealed confusion around the
ln_phi_purefunction which should be more accurately calledln_phi_pure_liquid