Conversation
I really cannot decipher the default printed form of VecIndexedWSet. This is better. Signed-off-by: Ben Pfaff <blp@feldera.com>
Signed-off-by: Ben Pfaff <blp@feldera.com>
cur_key held a factory-allocated Box<DynOpt<T::Key>>, cloned from the current key via from_ref() on every key transition. The clone is unnecessary: the key reference comes from `updates`, a parameter borrowed for the entire function call, so it stays valid across the whole loop (and the final flush after it). Builder::push_key also only ever takes a borrowed &Output::Key, never ownership. Hold a plain Option<&T::Key> instead, dropping one allocation and copy per unique key. We can't do the same thing for cur_val because it gets mutated in-place and even if we introduce some kind of Cow-like logic it ends up getting copied most of the time anyway. No measured macrobenchmark performance difference but it seems like an obvious improvement. Signed-off-by: Ben Pfaff <blp@feldera.com>
ryzhyk
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some minor cleanups and improvements that I've been sitting on for a while. See individual commit messages for details.