[manager] accept postgres_cdc_input as an input connector - #6810
Merged
Conversation
A table declaring a postgres_cdc_input connector failed to compile with "expected an input variant but got an output variant". generate_program_info matches the transport against an allow-list of input variants that omitted PostgresCdcInput, and the catch-all arm that follows reports every unlisted variant as an output variant. PR #5988 added the connector to feldera-types, to the SQL compiler's ConnectorValidator and to the adapter, but not to this allow-list, so the usage documented in docs.feldera.com/docs/connectors/sources/postgresql-cdc.md has never compiled on main. This is the same change as 19b8d33 on the unmerged pg-cdc-ft-fixes branch, split out so the fix does not wait on that branch.
mihaibudiu
approved these changes
Aug 5, 2026
mihaibudiu
enabled auto-merge
August 5, 2026 17:01
mythical-fred
approved these changes
Aug 5, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
One-line fix adding PostgresCdcInput to the connector allow-list in generate_program_info — matches the pattern for every other transport and unblocks the documented usage. Fixes #6807.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #5988 added the connector to feldera-types, to the SQL compiler's ConnectorValidator and to the adapter, but not to this allow-list, so the usage documented in
docs.feldera.com/docs/connectors/sources/postgresql-cdc.md has never compiled on main.
This is the same change as 19b8d33 on the unmerged pg-cdc-ft-fixes branch, split out so the fix does not wait on that branch.
Fixes #6807